adds google_cloud_run_service data source #7388
Conversation
ghost
requested a review
from 
| func dataSourceGoogleCloudRunService() *schema.Resource { | ||
|
|
||
| dsSchema := datasourceSchemaFromResourceSchema(resourceCloudRunService().Schema) | ||
| addRequiredFieldsToSchema(dsSchema, "name", "location") |
There was a problem hiding this comment.
We'll want to addOptionalFieldsToSchema for project as well, so it can be configured by the user.
| * `project` - (Optional) The project in which the resource belongs. If it | ||
| is not provided, the provider project is used. | ||
|
|
||
| * `region` - (Optional) The region in which the resource belongs. If it |
There was a problem hiding this comment.
This should be omitted, since it isn't a field on this resource (likely just a leftover?)
|
|
||
| ## Attributes Reference | ||
|
|
||
| TBD |
There was a problem hiding this comment.
You've got it right, imo- we should explicitly document the configurable parts and then link the resource documentation for the attributes.
|
hi @rileykarson, thanks for the comments I think I've addressed all now. Also, I've extended the test coverage to ensure Please let me know if there are more changes needed. |
There was a problem hiding this comment.
Thanks, LGTM!
I'm going to upstream this to Magic Modules (this repo is generated from there) before merging, so there'll be a slight delay, probably just a few hours, between this approving & merging.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Creates a data source for cloud run service as mentioned in #7363
Would be good to get the early feedback.
When it comes to documentation for time being, I left
TBDand still some references toCloud Functionas I used that for the template. For documentation object reference to do you copy text from resources or do you just link, what is the preferred way?Closes: #7363